Update ECR pattern to include C2S environments #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be great if somebody can review this and either approve or deny it. @austinvazquez, sorry to single you out, but I see you approved a PR recently. If you have a chance, could you please look at this? If anything changed, I'd be happy to contribute! |
|
Will close and reopen for CI to run. |
austinvazquez
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
As noted by author, change matches the pattern used by Kubernetes credential provider for AWS ECR. See here. So LGTM.
austinvazquez
changed the title
|
Thank you @austinvazquez ! |
|
Asking internally for one more reviewer. I'll help get this pushed through. |
sondavidb
approved these changes
Jan 8, 2024
turan18
approved these changes
Jan 8, 2024
|
Thanks @jrsherry for the change and @speedythesnailnpg for bringing it to my attention. Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#433
Description of changes:
Update the ecrPattern to include c2s environments
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.